Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure USB hub ports do not remain enabled after devices.query() completes device discovery, preventing “rogue” devices on unmapped/unused ports from appearing mid-test and interfering with device selection.
Changes:
- Disable all hub ports at the end of
devices.query()to reset the test environment to a clean baseline. - Wait for ports/devices to be fully disabled before proceeding.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
query()discovers devices, all hub ports are left enabledquery()so tests start from a clean stateenable_only()then enables only the port it needsRoot cause
Build #111290 on rsdsk255: D585S safety tests failed because a D435 on USB2.1 (loose cable, unmapped port) appeared during the test. The test found the D435 instead of D585S →
RuntimeError: Could not find requested sensor type!Test plan
enabled()state is consistent (all devices marked_removedafter disable)🤖 Generated with Claude Code