Skip to content

Remove Intel records from python wrapper - #14875

Merged
Nir-Az merged 2 commits into
developmentfrom
Nir-Az-patch-1
Apr 5, 2026
Merged

Nir-Az merged 2 commits into
developmentfrom
Nir-Az-patch-1

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings March 29, 2026 14:28
@Nir-Az
Nir-Az requested a review from AviaAv March 29, 2026 14:29

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Python wrapper documentation to remove “Intel” branding references, aligning the wrapper README with the “RealSense SDK 2.0” naming.

Changes:

  • Rename the README title to remove “Intel”.
  • Update the introductory sentence to remove “Intel”.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread wrappers/python/README.rst Resolved
Comment thread wrappers/python/README.rst Outdated
Comment on lines +1 to +4
Python Wrapper for RealSense SDK 2.0
==========================================

The python wrapper for Intel RealSense SDK 2.0 provides the C++ to Python binding required to access the SDK.
The python wrapper for RealSense SDK 2.0 provides the C++ to Python binding required to access the SDK.

Copilot AI Mar 29, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title suggests removing Intel branding from the Python wrapper, but there are still multiple "Intel RealSense" references under wrappers/python/examples (e.g., box_dimensioner_multicam/realsense_device_manager.py). Either update those remaining references or narrow/rename the PR to reflect that it only changes the README header.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread wrappers/python/README.rst Resolved

@AviaAv AviaAv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's handle Copilot's comments as they seem relevant


PYBIND11_MODULE(NAME, m) {
m.doc() = R"pbdoc(
LibrealsenseTM Python Bindings

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TM is not needed in this file?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not

@AviaAv AviaAv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@Nir-Az
Nir-Az merged commit 4d63a8a into development Apr 5, 2026
64 of 66 checks passed
@Nir-Az
Nir-Az deleted the Nir-Az-patch-1 branch April 5, 2026 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants