Repository navigation
checking mipi driver version for ext sync xu, py mipi driver moved to repr - #14846
Merged
Nir-Az merged 1 commit intoMar 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds MIPI driver version reporting to the Python device __repr__ and uses the MIPI driver version (on Jetson) to gate enabling the External Sync XU for GMSL/MIPI D400 devices, while simplifying Python-side device discovery logging.
Changes:
- Expose
RS2_CAMERA_INFO_MIPI_DRIVER_VERSIONin the Pythonrs2::device__repr__. - In
d400-device.cpp, query Jetson MIPI driver version and require a minimum driver version for registering the External Sync XU. - Remove custom Python unit-test logging for MIPI driver version during device query (now implicitly covered by
__repr__).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wrappers/python/pyrs_device.cpp | Adds MIPI driver version to Python device representation when supported. |
| unit-tests/py/rspy/devices.py | Simplifies device detection logging (removes explicit MIPI driver version logging). |
| src/ds/d400/d400-device.cpp | Retrieves Jetson MIPI driver version, registers it as camera info, and gates External Sync XU by driver version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Nir-Az
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-5861 and RSDSO-21262