Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the firmware update unit test to use the correct DFU opcode for reading/resetting the downgrade counter and to correct flash-lock detection behavior.
Changes:
- Replace update-counter logic with downgrade-counter logic using DFU_READ_CNT (0x93) and rename helpers accordingly.
- Fix flash-lock detection by treating
camera_locked == 'YES'as locked and resetting the downgrade counter in that case. - Add explicit D500 handling (no downgrade counter support) in the counter helpers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
ipilchin1
force-pushed
the
RSDSO-21295_fw-update-flash-lock-fix
branch
from
March 18, 2026 10:20
1820e6e to
2304be4
Compare
…ction - Replace get_update_counter (FRB opcode 0x09 at wrong offset) with get_downgrade_counter using DFU_READ_CNT opcode 0x93 - Rename reset_update_counter to reset_downgrade_counter for clarity - Fix camera_locked check: compare against 'YES' instead of 'UNLOCKED' (device returns 'YES'/'NO', not 'UNLOCKED') - Reset downgrade counter when flash-lock detected after FW update - Add D500 skip support in counter functions
ipilchin1
force-pushed
the
RSDSO-21295_fw-update-flash-lock-fix
branch
from
March 18, 2026 10:32
2304be4 to
31ba4d1
Compare
Nir-Az
reviewed
Mar 18, 2026
Nir-Az
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.