Repository navigation
BUILD_WITH_NEON flag added in cmake config and in code - #14816
Merged
remibettan merged 11 commits intoMar 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a build-time toggle to control whether ARM NEON-optimized processing paths are compiled/selected, aligning the CMake configuration with compile-time guards in the processing code.
Changes:
- Introduces
BUILD_WITH_NEONCMake option and propagates it into C/C++ via-DBUILD_WITH_NEON. - Gates NEON-optimized implementations (align, pointcloud, YUY2 unpacking) behind
defined(BUILD_WITH_NEON)in addition to__ARM_NEON. - Updates Unix ARM (32-bit) compiler flags to only apply
-mfpu=neonwhenBUILD_WITH_NEONis enabled.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/proc/pointcloud.cpp | Only selects NEON pointcloud implementation when BUILD_WITH_NEON is enabled. |
| src/proc/neon/neon-pointcloud.h | Guards NEON pointcloud class declaration behind BUILD_WITH_NEON. |
| src/proc/neon/neon-pointcloud.cpp | Guards NEON pointcloud implementation behind BUILD_WITH_NEON. |
| src/proc/neon/neon-align.h | Guards NEON align helper/classes behind BUILD_WITH_NEON. |
| src/proc/neon/neon-align.cpp | Guards NEON align implementation behind BUILD_WITH_NEON. |
| src/proc/neon/image-neon.h | Guards NEON YUY2 unpack prototypes behind BUILD_WITH_NEON. |
| src/proc/neon/image-neon.cpp | Guards NEON YUY2 unpack implementation behind BUILD_WITH_NEON. |
| src/proc/color-formats-converter.cpp | Only uses NEON unpack path when BUILD_WITH_NEON is enabled. |
| src/proc/align.cpp | Only selects NEON align implementation when BUILD_WITH_NEON is enabled. |
| CMake/unix_config.cmake | Applies ARM NEON-related compile flags conditionally based on BUILD_WITH_NEON. |
| CMake/lrs_options.cmake | Adds BUILD_WITH_NEON option (default ON). |
| CMake/global_config.cmake | Defines BUILD_WITH_NEON compile macro when the option is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Nir-Az
reviewed
Mar 16, 2026
Nir-Az
reviewed
Mar 16, 2026
remibettan
force-pushed
the
adding-cmake-flag-for-neon
branch
from
March 17, 2026 09:17
f3359f5 to
dd09c88
Compare
Nir-Az
reviewed
Mar 17, 2026
Nir-Az
reviewed
Mar 17, 2026
Nir-Az
approved these changes
Mar 17, 2026
Nir-Az
left a comment
Nir-Az
left a comment
Collaborator
There was a problem hiding this comment.
Approved just add the message
Nir-Az
reviewed
Mar 18, 2026
Nir-Az
reviewed
Mar 18, 2026
Nir-Az
changed the title
Nir-Az
reviewed
Mar 19, 2026
…forcing vfpv3-d16 flags
remibettan
force-pushed
the
adding-cmake-flag-for-neon
branch
from
March 19, 2026 14:20
93c4d5c to
d34e184
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-6251