Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the test-fw-update.py unit test to catch firmware update failures earlier and to surface potential flash-lock state after updating, addressing silent FW update failures observed on D457 GMSL.
Changes:
- Capture and validate
rs-fw-updateexit code; fail the test immediately on non-zero exit. - Add a post-update check that warns if the device string no longer indicates
UNLOCKED.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ipilchin1
force-pushed
the
RSDSO-21295_fw-update-flash-lock-fix
branch
from
March 9, 2026 14:04
232761e to
e5257aa
Compare
…date - Check rs-fw-update subprocess return code; fail early if non-zero - Detect flash lock (GVD offset 25) by checking for UNLOCKED in device string after FW update and log a warning for CI visibility
ipilchin1
force-pushed
the
RSDSO-21295_fw-update-flash-lock-fix
branch
from
March 9, 2026 14:15
e5257aa to
d258ba6
Compare
Nir-Az
reviewed
Mar 9, 2026
Nir-Az
reviewed
Mar 9, 2026
Nir-Az
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test-fw-update.py to prevent silent FW update failures that leave D457 GMSL cameras flash-locked (GVD offset 25).
Changes:
Check rs-fw-update exit code; fail early if non-zero instead of proceeding to version assertion
Detect flash lock after FW update by checking for UNLOCKED in device string and log a warning
Root cause: On D457 GMSL, rs-fw-update reported "Firmware update done" but the FW version didn't change (downgrade silently rejected). The test continued and failed on version mismatch, while the camera was left flash-locked.