Skip to content

Update UT frequencies to reduce run time - #14777

Merged
Nir-Az merged 6 commits into
realsenseai:developmentfrom
OhadMeir:unit-tests
Mar 2, 2026
Merged

Nir-Az merged 6 commits into
realsenseai:developmentfrom
OhadMeir:unit-tests

Conversation

@OhadMeir

@OhadMeir OhadMeir commented Mar 1, 2026

Copy link
Copy Markdown
Contributor

Tracked on [RSDEV-6165]

Copilot AI review requested due to automatic review settings March 1, 2026 15:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts live unit-test run frequencies (nightly/weekly gating) to reduce overall CI runtime (tracked in RSDEV-6165), and shortens/quietens parts of FPS testing to further cut execution time.

Changes:

  • Updated many live test headers to add/modify test:donotrun context directives (e.g., move from nightly to weekly, or skip outside nightly).
  • Reduced FPS test runtime by shortening per-FPS measurement windows and adjusting steady-state timing.
  • Added frame-drop detection/logging tweaks in fps_helper.py and removed an obsolete DDS detection test.

Reviewed changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
unit-tests/live/tools/test-dds-config.py Adds donotrun:!nightly gating and normalizes directive formatting.
unit-tests/live/streaming/test-jpeg-compressed-format.py Adds donotrun:!nightly gating.
unit-tests/live/rec-play/test-playback-stress.py Moves to weekly gating; adjusts a debug log label.
unit-tests/live/rec-play/test-pause-playback-frames.py Moves to weekly gating; expands device coverage to D500*.
unit-tests/live/rec-play/test-non-realtime.py Moves to weekly gating.
unit-tests/live/options/test-uvc-power-stress-test.py Moves from nightly to weekly gating.
unit-tests/live/options/test-set-gain-stress-test.py Moves from nightly to weekly gating; relocates header comment.
unit-tests/live/intrinsics/test-motion.py Adds weekly gating and clarifies header comment.
unit-tests/live/image-quality/test-texture-mapping.py Adds donotrun:!nightly gating with rationale comment.
unit-tests/live/image-quality/test-basic-depth.py Adds donotrun:!nightly gating with rationale comment.
unit-tests/live/image-quality/test-basic-color.py Adds donotrun:!nightly gating with rationale comment.
unit-tests/live/fw-logs/test-legacy.py Updates run gating and device scope for legacy FW logging test.
unit-tests/live/fw-logs/test-extended.py Adds donotrun:!nightly gating; removes commented DDS skip directive.
unit-tests/live/frames/test-fps-single-stream.py Shortens per-FPS test durations; adjusts steady-state time.
unit-tests/live/frames/fps_helper.py Adds previous-frame tracking + frame-drop warning and reduces debug logging; updates callback wiring.
unit-tests/live/debug_protocol/test-hwmc-errors.py Moves to weekly gating.
unit-tests/live/debug_protocol/test-build-command.py Adds donotrun:!nightly gating.
unit-tests/live/d500/test-temperatures-xu-vs-hwmc.py Adds donotrun:!nightly gating.
unit-tests/live/d500/test-read-serial-number.py Adds weekly gating.
unit-tests/live/d500/test-get-set-config-table.py Adds donotrun:!nightly gating.
unit-tests/live/d500/test-detect-dds-device.py Removes obsolete DDS detection test.
unit-tests/live/d500/test-dds-embedded-filters.py Adds donotrun:!nightly gating in addition to existing DDS gating.
unit-tests/live/d500/safety/test-verify-default-preset.py Adds donotrun:!nightly gating.
unit-tests/live/d500/safety/test-smcu-version.py Adds donotrun:!nightly gating.
unit-tests/live/d500/safety/test-preset-get-set.py Moves from nightly to weekly gating.
unit-tests/live/d500/safety/test-preset-get-set-index-checks.py Adds donotrun:!nightly gating.
unit-tests/live/d500/safety/test-preset-active-index-set-get.py Adds donotrun:!nightly gating.
unit-tests/live/d500/safety/test-metadata.py Adds donotrun:!nightly gating.
unit-tests/live/d500/safety/test-app-config-get-set-hwm-cmd.py Adds donotrun:!nightly gating.
unit-tests/live/d500/safety/test-app-config-get-set-api.py Adds donotrun:!nightly gating.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread unit-tests/live/fw-logs/test-legacy.py Resolved
Comment thread unit-tests/live/frames/fps_helper.py Resolved
@Nir-Az

Nir-Az commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

@OhadMeir we need to decide 2 things.

  1. We still we need a minimal test for most features (like rec & play) for example, are they any left at gating
  2. If we remove all IQ , FW will need to use nightly as gating

@OhadMeir

OhadMeir commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

@OhadMeir we need to decide 2 things.

  1. We still we need a minimal test for most features (like rec & play) for example, are they any left at gating
  2. If we remove all IQ , FW will need to use nightly as gating

Restored IQ tests. Used nightly run to measure tests run time and as gating it run faster.
The mechanism of using test context to set iterations/parameters is good but confused me when checking the times.

Other features I left at nightly only, such as FW errors, FW logs, embedded filters, safety camera tests, etc, as these are features that seldom update even in FW.

@OhadMeir
OhadMeir requested a review from Nir-Az March 2, 2026 07:50
@Nir-Az
Nir-Az merged commit 6f168df into realsenseai:development Mar 2, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants