Repository navigation
T2ff sensor enhance info + skills update - #14769
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the T2FF (time-to-first-frame) sensor live test to capture/report the actual first-frame arrival time even when it exceeds the KPI (up to KPI + 1s), and refreshes repository guidance so agents/developers use the documented build/testing “skills” correctly.
Changes:
- Update
test-t2ff-sensor.pyto use a “no-frame” sentinel and to print/check first-frame timing even if it arrives after the KPI. - Improve testing documentation with Windows-oriented examples and troubleshooting notes.
- Update agent instructions to reference
.github/skills/*as the source of truth for build/test how-tos.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
unit-tests/live/frames/test-t2ff-sensor.py |
Adjusts first-frame timing logic to report late frames (up to KPI+1s) and adds explicit “no frames arrived” checks. |
.github/skills/testing.md |
Updates test-running examples and adds notes on .pyd ambiguity and test-name/regex matching. |
.github/agent-instructions.md |
Adds a “Skills” section and points build/testing guidance to the skill files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…sting.md Windows example - Update time_to_first_frame docstring: return value on timeout is -1, not max_delay_allowed - Fix depth/color 'no frames' error messages to report max_delay_allowed+1 (the actual wait window) - Fix malformed Windows example in testing.md (extra space in path, wrong flags)
Nir-Az
force-pushed
the
t2ff-sensor-enhance
branch
from
March 2, 2026 18:27
10be072 to
42eee6c
Compare
OhadMeir
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We wish to print the actual time the frame arrived even if pass the KPI (until 1 sec post KPI)
Also update the agent instructions to use the skills properly and the testing skill to better understand how to run tests