Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase by moving D400-specific GVD (General Vision Data) offset definitions and related firmware details extraction logic from the common DS (depth sensor) scope into the D400-specific scope.
Changes:
- Relocated
d400_gvd_offsetsnamespace fromds-private.htod400-private.h - Moved
get_fw_details()method fromds_device_commonclass tod400_deviceclass - Updated function call in
d400-device.cppto use the new local method instead of the common implementation
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/ds/ds-private.h | Removed D400-specific GVD offset constants from common DS header |
| src/ds/ds-device-common.h | Removed get_fw_details() method declaration from common device class |
| src/ds/ds-device-common.cpp | Removed get_fw_details() implementation from common device class |
| src/ds/d400/d400-private.h | Added D400-specific GVD offset constants to D400 private header |
| src/ds/d400/d400-device.h | Added get_fw_details() method declaration to D400 device class |
| src/ds/d400/d400-device.cpp | Added get_fw_details() implementation and updated call site to use local method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
Nir-Az
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactor