Repository navigation
Pause playback device as part of subdevice model - #14593
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors playback device pause/resume functionality by moving the playback control logic from the stream model UI layer into the subdevice model. This consolidates the playback state management in a single location and removes redundant code from the UI button handlers.
Changes:
- Moved playback device pause/resume logic from stream-model.cpp to subdevice-model.cpp
- Added playback status checks before pausing/resuming to ensure operations only occur when appropriate
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| common/subdevice-model.cpp | Added playback device pause/resume calls with status checks in the pause() and resume() methods |
| common/stream-model.cpp | Removed redundant playback pause/resume calls from UI button handlers, now delegated to subdevice model |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Nir-Az
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on: [RSDEV-3814]