Repository navigation
update expected filename on fw update test - #14451
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the firmware version extraction logic in the test suite to handle a more specific filename format. The regex pattern now expects underscores as delimiters and explicitly matches .bin or .img file extensions.
Key changes:
- Modified regex pattern to use underscores exclusively and capture file extensions
- Added logic to exclude the file extension from version groups
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| filename = os.path.basename(file_path) | ||
| match = re.search(r'[-_](\d+)[._](\d+)[._](\d+)[._](\d+)', filename) | ||
| match = re.search(r'_(\d+)_(\d+)_(\d+)_(\d+).(bin|img)', filename) |
There was a problem hiding this comment.
The dot before (bin|img) should be escaped as \. to match a literal period. Without escaping, it matches any character, which could lead to false positives in filename matching.
Suggested change
| match = re.search(r'_(\d+)_(\d+)_(\d+)_(\d+).(bin|img)', filename) | |
| match = re.search(r'_(\d+)_(\d+)_(\d+)_(\d+)\.(bin|img)', filename) |
Contributor
Author
There was a problem hiding this comment.
Correct, but we can ignore for now as dot matches a dot too
Nir-Az
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on: [LRS-1349]