Repository navigation
fix wrong string compare on python device repr - #14417
Merged
Merged
Conversation
Nir-Az
force-pushed
the
fix-usb-desc
branch
7 times, most recently
from
November 6, 2025 12:44
c2b358f to
2c0cedb
Compare
AviaAv
reviewed
Nov 6, 2025
| run: | | ||
| echo "Running clang-tidy..." | ||
| cp build/compile_commands.json . | ||
| clang-tidy -p . $(find src -name '*.cpp') 2>&1 | tee clang-tidy.log |
Contributor
There was a problem hiding this comment.
Is this expected to catch char* to char* comparisons instead of strings?
Collaborator
Author
There was a problem hiding this comment.
WIP, will update when done
If not it will be excluded from this PR
Nir-Az
force-pushed
the
fix-usb-desc
branch
9 times, most recently
from
November 9, 2025 10:04
d68ee31 to
fcdbe1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrong string comparation cause the condition to fail.
We compared char * to "USB" and not used proper string comparation
Before:
After: