Repository navigation
Fix D555 recovery mode not recognized - #14375
Merged
Merged
Conversation
Nir-Az
reviewed
Oct 23, 2025
| _depth_sensor = base; | ||
| } | ||
| if( !_depth_sensor ) | ||
| if( !_depth_sensor && !dynamic_cast<update_device_interface *> (dev) ) |
Collaborator
There was a problem hiding this comment.
Why do we run this code on recovery mode? Is it inherent from a recovery device?
Contributor
Author
There was a problem hiding this comment.
Calls it, on c'tor of dds_device_proxy
Contributor
There was a problem hiding this comment.
See my message about checking if recovery in rs-dds-device-proxy.
USB recovery devices are not ds_advanced_mode_base (so not trying to initialize), but for DDS we inherit it without knowing in advance if we are a recovery device or not.
Contributor
Author
There was a problem hiding this comment.
Moved to rs-dds-device-proxy
Nir-Az
changed the title
OhadMeir
approved these changes
Oct 26, 2025
Nir-Az
approved these changes
Oct 26, 2025
AviaAv
pushed a commit
to AviaAv/librealsense
that referenced
this pull request
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for PR #14313, specifically commit 0b8683b, after which DDS devices in recovery mode would throw an error in the viewer and would not show in viewer
Seems like removing the caused it indirectly