Repository navigation
Adding string to opcode mismatch error - #13498
Merged
Merged
Conversation
Collaborator
|
PLease see CI errors |
Nir-Az
reviewed
Nov 7, 2024
Nir-Az
reviewed
Nov 7, 2024
| rs2_raw_data_buffer* rs2_terminal_parse_response(rs2_terminal_parser* terminal_parser, | ||
| const char* command, unsigned int size_of_command, | ||
| const void* response, unsigned int size_of_response, rs2_error** error); | ||
| const void* response, unsigned int size_of_response, const char* error_opcode_to_string, rs2_error** error); |
Collaborator
There was a problem hiding this comment.
This is an API change right?
I see this code is used in several wrappers
Contributor
Author
There was a problem hiding this comment.
yes, this is why some CI builds have failed initially, but they pass now after I changed the use there
Nir-Az
reviewed
Nov 7, 2024
Nir-Az
reviewed
Nov 7, 2024
AviaAv
force-pushed
the
hw-monitor-enhance
branch
from
November 10, 2024 15:20
a746977 to
defc911
Compare
Nir-Az
reviewed
Nov 11, 2024
Nir-Az
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on: [LRS-1105]