Skip to content

chore: remove tomli from vendor - #6417

Merged
matteius merged 5 commits into
mainfrom
remove-tomli
Jun 9, 2025
Merged

matteius merged 5 commits into
mainfrom
remove-tomli

Conversation

@oz123

@oz123 oz123 commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Instead, use the tomli from bundeled pip.

Pretty small and quick to review ;-)

Instead, use the tomli from bundeled pip.

Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
@oz123
oz123 requested a review from matteius June 9, 2025 06:40
@matteius

matteius commented Jun 9, 2025

Copy link
Copy Markdown
Member

I seem to recall there needing to be a change to the vendor script to support this better during revendoring.

oz123 added 4 commits June 9, 2025 17:14
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
All removed search-replace tupples are
for packages we no longer vendor...

Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
@oz123

oz123 commented Jun 9, 2025

Copy link
Copy Markdown
Contributor Author

I seem to recall there needing to be a change to the vendor script to support this better during revendoring.

Indeed, tomli search and replace was part of the vendor script, but it is no longer needed as we removed the library from out vendor directory.
As I already touched it now, I pushed a few more commits doing some more cleanup of this script.

@matteius
matteius merged commit 12fda47 into main Jun 9, 2025
@matteius
matteius deleted the remove-tomli branch June 9, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants