Repository navigation
DOC: Execute file-writing examples in temporary notebook directories - #11711
Merged
headtr1ck merged 1 commit intoOct 17, 2026
Merged
Conversation
headtr1ck
approved these changes
Oct 16, 2026
headtr1ck
left a comment
headtr1ck
left a comment
Collaborator
There was a problem hiding this comment.
Didn't know that's a thing, thanks!
|
Congratulations on completing your first pull request! Welcome to Xarray! We are proud of you, and hope to see you again! |
Contributor
Me too, thanks! |
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #11458 for the Time Coding and Complex Numbers pages.
The examples retain lazy NetCDF datasets in the notebook kernel, so deleting their temporary files inside the notebook fails on Windows. Use MyST-NB's per-page
execution_in_tempsetting and remove the hidden directory setup, filename prefixing, and cleanup cells. The executor then removes its temporary directory after the kernel exits. The visible examples and lazy reads are unchanged.Validation on Windows with MyST-NB 1.4: both original pages reproduced
WinError 32; both patched pages executed successfully in a targeted Sphinx build. All seven generated files permitted DELETE access after kernel shutdown, and one file per page was unlinked. The harness retained other files instead of recursively deleting them. Displayed results matched, apart from generated HTML UUIDs. The full documentation build was not run; the two-page fixture had four unresolved references to excluded documentation.Checklist
AI Disclosure
Tools: Codex, used for implementation, automated validation, review, and drafting this description. The submitter personally reviewed and understood the patch, then requested another AI review before submission. Automated test execution was performed by Codex.
Prompts: try fixing the reported issues and submit PRs; after personal review, review the changes again and make necessary improvements before submitting.