Repository navigation
fix: round subpixel coordinates for glyph background rectangles - #892
Merged
Merged
Conversation
`cosmic-term` currently has an issue where borders appear to separate some cells columnwise. This was caused due to the accumulation of floating point error when using font sizes that can't be fully represented in an f32. For example, a font size of 8.4x20 and a unique color per cell is enough to reproduce this. Essentially, the glyph background rectangles are being drawn slightly too narrow, causing the terminal background to leak through. This patch rounds the rectangles in such a way that we guarantee the drawing of that "border" pixel using floor() and ceil().
jackpot51
approved these changes
Jul 29, 2026
jacobktm
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cosmic-termcurrently has an issue where borders appear to separate some cells columnwise. This was caused due to the accumulation of floating point error when using font sizes that can't be fully represented in an f32. For example, a font size of 8.4x20 and a unique color per cell is enough to reproduce this. Essentially, the glyph background rectangles are being drawn slightly too narrow, causing the terminal background to leak through. This patch rounds the rectangles in such a way that we guarantee the drawing of that "border" pixel using floor() and ceil().