Skip to content

fix: only PaneClicked events change focus - #864

Merged
jacobgkau merged 1 commit into
pop-os:masterfrom
RipleyTom:focus_fix
Jul 14, 2026
Merged

jacobgkau merged 1 commit into
pop-os:masterfrom
RipleyTom:focus_fix

Conversation

@RipleyTom

Copy link
Copy Markdown
Contributor

This changes the focus logic so that clicking the title bar(to move the window around) or resize buttons doesn't automatically unfocus the current pane. All the pane focus logic goes through PaneClicked=>update_focus.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@git-f0x

git-f0x commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

I seems cosmic-edit also has the text box getting unfocused in similar cases.

@jackpot51
jackpot51 requested review from a team July 9, 2026 18:46
@RipleyTom

RipleyTom commented Jul 10, 2026 •

Copy link
Copy Markdown
Contributor Author

I've made a more generic libcosmic fix that fixes all applications focus issues with libcosmic: pop-os/libcosmic#1342 . If it's accepted I'll just close this.
The libcosmic fix is a bit better as this only affects the panes but not for example the search edit, which loses focus if you move the window.

@RipleyTom

Copy link
Copy Markdown
Contributor Author

Nvm about the generic libcosmic thing, it's scrapped.

@LinuxGratos

Copy link
Copy Markdown

This is the fix we needed ! Thank you
It was bothering me that the terminal loses focus
Too bad it won't be in 1.3.0 ๐Ÿ˜ข

@dania83

dania83 commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

I confirm. I have a problem of terminal hung when I use maximize button. With this commit the problem is resolved

@jacobgkau jacobgkau self-assigned this Jul 14, 2026

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes keyboard focus after clicking/dragging the titlebar. All menu options are still working as expected.

@jacobgkau
jacobgkau merged commit 44d042f into pop-os:master Jul 14, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants