Skip to content

Center text in places where container content is aligned to center - #579

Merged
mmstick merged 1 commit into
pop-os:masterfrom
mkljczk:text-center
Jul 23, 2026
Merged

mmstick merged 1 commit into
pop-os:masterfrom
mkljczk:text-center

Conversation

@mkljczk

@mkljczk mkljczk commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

got annoyed by text being wrapped like this
image

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Signed-off-by: nicole mikołajczyk <git@mkljczk.pl>
@leviport
leviport requested review from a team July 23, 2026 21:35
@leviport leviport self-assigned this Jul 23, 2026

@leviport leviport left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only seeing the non-centered text at a specific window width, but this PR definitely fixes it. Thanks for the fix!

After:
Image

Before:
Image

Regression testing passed: - [x] Able to install & remove a Flatpak app. - [x] Able to install & remove a Deb app. - [x] Able to install Deb updates. - [x] Searching still works. - [x] Browsing categories still works. - [x] Able to remove & re-add Flatpak sources.

@leviport leviport removed their assignment Jul 23, 2026
@mkljczk

mkljczk commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

I think I encountered this first while running COSMIC/COSMIC apps on a phone, which is probably not the supported way of using it :D but this can also occur at some widths, for some unordinary developer names or in certain UI localizations

@mmstick
mmstick merged commit f0ebf89 into pop-os:master Jul 23, 2026
7 checks passed
@git-f0x

git-f0x commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

Huh, I thought centered wrap wasn't supported by iced/cosmic-text (maybe 0.14 implemented it?). The same should probably be done for the App Library and the grid file names in COSMIC Files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants