Skip to content

fix(display): arrangement not redrawing while dragging displays - #2180

Merged
mmstick merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/fix-request-redraw
Aug 29, 2026
Merged

mmstick merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/fix-request-redraw

Conversation

@hojjatabdollahi

Copy link
Copy Markdown
Contributor

dragging displays to reposition them should now be as smooth as before.

(mentioned here)


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@mmstick
mmstick requested a review from a team August 28, 2026 17:43
@jacobktm jacobktm self-assigned this Aug 28, 2026

@jacobktm jacobktm left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smooth as butter.

This has passed regression testing. # Testing

This document provides a regression testing checklist for COSMIC Settings and the COSMIC Settings Daemon. The checklist provides a starting point for Quality Assurance reviews.

Checklist

Network & Wireless

Wi-Fi

  • Able to disconnect from and connect to a network.

Bluetooth

  • Bluetooth device connects.
  • Paired device can be disconnected & reconnected.
  • Paired device can be forgotten & connecting again works.

Desktop

Wallpaper

  • Clicking a different wallpaper switches to it immediately
  • Leaving the page and coming back does not change the wallpaper

Appearance

  • Open a COSMIC app and a GNOME app. When switching between Dark and Light mode, the COSMIC app switches immediately, and the GNOME app switches after restarting.
  • Changing the accent color works.
  • Changing the roundness style works and does not affect other aspects of the theme (e.g. color mode).
  • Changing the interface density works.

Panel

  • Enable tiling. "Automatically hide panel" takes effect immediately.
  • Disable tiling; maximize a window. "Automatically hide panel" takes effect immediately.

Dock

  • Enable tiling. "Automatically hide dock" takes effect immediately.
  • Disable tiling; maximize a window. "Automatically hide dock" takes effect immediately.
  • Changing position on screen works.
  • All Style settings take effect as expected.

Displays

  • Plug in a second display. Displays can be rearranged via dragging.

Sound

  • Output & Input volume sliders work independently
  • Output balance slider works & doesn't get reset by volume slider
  • Amplification toggles work as expected
  • Device profiles can be changed & reflect as expected on the main Sound page
  • Applications using sound appear on the Applications sub-page
  • Application volume and mute controls only affect the selected playback stream
  • Closing an playback stream removes it from the Applications sub-page

Power & Battery

  • Changing power mode takes effect and is reflected by top panel applet.

Input Devices

Touchpad

  • All click behavior settings work as expected.
  • All scrolling settings work as expected.

Applications

Default Applications

  • Changing the default terminal affects Super-T shortcut.

X11 Applications Compatibility

  • Global Shortcuts in X11 Applications work (in e.g. Discord).

Time & Language

Date & Time

  • Changing time zone works.
  • Toggling 24-hour time takes effect in Settings preview, on top panel, and on the lock screen.
  • Toggling seconds takes effect in Settings preview and on top panel.
  • Changing first day of week takes effect in Calendar applet.
  • Turning date on/off for applet works.

System & Accounts

About

  • Changing hostname works (check terminal prompt).

@mmstick
mmstick merged commit 4b4b688 into pop-os:master Aug 29, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants