Skip to content

Fix high cpu usage when screen is locked - #653

Merged
mmstick merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/fix-high-cpu
Jul 28, 2026
Merged

mmstick merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/fix-high-cpu

Conversation

@hojjatabdollahi

@hojjatabdollahi hojjatabdollahi commented Jul 24, 2026 •

Copy link
Copy Markdown
Contributor

is_dirty is cleared only in render but when screen is locked we don't get any render callbacks. So, is_dirty stays true and we get stuck in a relayout loop.

I introduced a new flag that clears needs_layout so we don't redo layout, and is_dirty will be cleared whenever we render.

Fixes #645


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@mmstick
mmstick requested a review from a team July 24, 2026 07:13
@jacobktm jacobktm self-assigned this Jul 24, 2026
@mmstick
mmstick merged commit d6699ff into pop-os:master Jul 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issue: sustained multi-second CPU monopolization causing compositor frame drops

3 participants