Repository navigation
Conversation
Do nothing here if the surface belongs to a different panel.
Member
Author
ids1024
marked this pull request as ready for review
July 28, 2026 04:09
wash2
approved these changes
Jul 28, 2026
leviport
approved these changes
Jul 28, 2026
leviport
left a comment
leviport
left a comment
Member
There was a problem hiding this comment.
Touch clicking applets works much better after this fix.
Softer
added a commit
to Lin-WMDE/wmde-panel
that referenced
this pull request
Jul 30, 2026
…lass maximize fix Brings in 9 upstream commits, all confined to cosmic-panel-bin/src: - fix: separate needs_layout and needs_render (internal render-loop optimization in space/layout.rs, panel_space.rs, wrapper_space.rs, space_container.rs) - Merge pop-os#550 "touch": WrapperSpace::add_popup loses latest_seat/ latest_serial, gains grab_popup; popups are no longer grabbed unconditionally on creation (14284eb, 5dd9408); keyboard_leave now ignores events for unrecognized wl_surface (764cdf4); space_container gains space_for_client_mut to de-duplicate lookup code (b237655) - fix: close popups on all outputs before adding a new one - fix: flickering when using frosted glass with preserve panel/dock style on window maximize - apply_config() split out of update_config(), apply_current_maximized_state() added, toplevel.rs::apply_maximized rewritten to read from config_list instead of the space's own config (opacity forced to 1.0 while maximized) - fix: frosted-glass applets updated on hotplugged external monitor Merge was completely conflict-free (git detected only an auto-merge in wrapper_space.rs, no manual resolution needed). Cargo.toml, Cargo.lock, data/default_schema, PKGBUILD and cosmic-panel-config are untouched by upstream, so the WMDE rebrand (fun.wmde.Panel, WMDE_PANEL_* env vars, Win10-style single-panel schema) is unaffected. No COSMIC branding regressions found in the changed files (ASCII or transliterated) - remaining "cosmic"/"Cosmic" occurrences are load-bearing crate types (CosmicPanelConfig, CosmicPanelContainerConfig, cosmic_workspaces field). Known follow-up (out of scope here): cosmic-panel-config's compiled Default in container_config.rs still produces the two-bar upstream layout (Panel + Dock) rather than the single-panel Win10 layout in data/default_schema; to be fixed in a separate local commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two fixes here seem to solve the same problem as #470 in a cleaner way.
keyboard_leaveevents for a different panel, instead of closing popupsThe later change though seems to basically be a revert of #424, looking at the history of this code. But I don't really understand why that fix was needed. The applet clients create grabs, so cosmic-panel ends up creating a grab either way? Nor should "focus follows cursor" require a grab (or that would presumably be a compositor bug), and I'm not seeing issues with that...