Skip to content

Use build.rs for xdgen - #459

Merged
jacobgkau merged 2 commits into
masterfrom
xdgen
Aug 26, 2026
Merged

jacobgkau merged 2 commits into
masterfrom
xdgen

Conversation

@mmstick

@mmstick mmstick commented Aug 26, 2026

Copy link
Copy Markdown
Member

Switch to using a build.rs for xdgen to avoid the need to run it as a cargo script during the vendoring phase. This adds export LOCKSTEP_XML_PATH := absolute_path('vendor/atspi-common/xml') to the justfile to work around the build error in atspi-common when the xml crate is vendored alongside it.

Reference: luukvanderduim/zbus-lockstep#9

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Requires manually setting `LOCKSTEP_XML_PATH` to fix the atspi-common
build error in zbus-lockstep.
@mmstick
mmstick requested review from a team August 26, 2026 17:44

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .desktop file is identical after this change.

Still working as expected (regression testing passed):

Launcher

  • Cut text from the launcher, then close it; pasting into an app works
  • All windows on all workspaces appear on launch
  • Choosing an app on another workspace moves workspaces and focus to that app
  • Launching an application works
  • Typing text and then removing it will re-show those windows
  • Search works for applications and windows
  • Search works for COSMIC settings panels
  • Open windows are sorted above applications (e.g. "firefox")
  • t: executes a command in a terminal
  • : executes a command in sh
  • = calculates an equation
  • Search results are as expected:
    • cal returns LibreOffice Calc first
    • pops returns Popsicle first
    • shop returns the COSMIC Store first

@jacobgkau
jacobgkau merged commit 402103d into master Aug 26, 2026
7 checks passed
@jacobgkau
jacobgkau deleted the xdgen branch August 26, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants