Skip to content

fix: the logic for resize direction in tiling mode - #2880

Merged
Drakulix merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/fix-resize
Sep 25, 2026
Merged

Drakulix merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/fix-resize

Conversation

@hojjatabdollahi

Copy link
Copy Markdown
Contributor

The previous logic for resizing in tiling mode was wrong.
Just open 4 windows and try to see what the compositor decides when you move the cursor on the gaps for resizing!


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@Drakulix

Copy link
Copy Markdown
Member

Just open 4 windows and try to see what the compositor decides when you move the cursor on the gaps for resizing!

Seems to be working for me, can you be more precise?

@hojjatabdollahi

hojjatabdollahi commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor Author

You can see in this video you can't change window width using the vertical gap between windows. It changes the height of the windows for the top two windows, and for the bottom two it does nothing!

recording-2026-09-23_14-29-34-trimmed.mp4

@Drakulix Drakulix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay yeah, got it. LGTM

@Drakulix
Drakulix requested a review from a team September 24, 2026 13:56
@hojjatabdollahi
hojjatabdollahi marked this pull request as ready for review September 24, 2026 15:14
@jklgrasso jklgrasso self-assigned this Sep 24, 2026
@Drakulix
Drakulix merged commit 9f746ea into pop-os:master Sep 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants