Repository navigation
shell/focus: Don't dismiss grabbing popups of exclusive layer surfaces - #2845
Merged
jacobgkau merged 1 commit intoSep 16, 2026
Merged
Conversation
hojjatabdollahi
marked this pull request as ready for review
September 10, 2026 23:15
hojjatabdollahi
force-pushed
the
hojjat/fix-popup-exclusive
branch
from
September 15, 2026 22:30
d877054 to
550d120
Compare
hojjatabdollahi
force-pushed
the
hojjat/fix-popup-exclusive
branch
from
September 15, 2026 22:31
550d120 to
85f0902
Compare
ids1024
approved these changes
Sep 15, 2026
ids1024
left a comment
Member
There was a problem hiding this comment.
It seems correct to treat popups on an exclusive layer as valid keyboard targets.
6 tasks done
Contributor
Author
|
For QA, this can be tested with pop-os/cosmic-app-library#408. That PR without this fix: recording-2026-09-15_17-44-07.mp4With this fix: recording-2026-09-15_17-52-19.mp4 |
jacobgkau
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added context menu to all input boxes for copy/cut/paste in libcosmic. It works in all libcosmic apps, except for
app-libraryandcosmic-launcher.Turns out
cosmic-comp's focus refresh decides that a context menu is not allowed to have focus whileapp-libraryis open. Sinceapp-libraryopens withKeyboardInteractivity::Exclusiveand refresh-focus has a rule that if a surface has exclusive keyboard interactivity then no pop up is a valid focus target, it ungrabs the pop up in the next tick.The solution would be to check if the parent of the pop up is the surface with exclusive keyboard interactivity and allow it.
Our discussion in mattermost.