Skip to content

protocols/keyboard-layout: Send ei modifiers on group change - #2815

Merged
Drakulix merged 1 commit into
masterfrom
ei-group
Sep 3, 2026
Merged

Drakulix merged 1 commit into
masterfrom
ei-group

Conversation

@ids1024

@ids1024 ids1024 commented Sep 2, 2026

Copy link
Copy Markdown
Member

This makes cosmic-osk show a group change on super+space. Previously a change like that wouldn't be sent until a keyboard input changed the modifier state, for instance releasing the shift key.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

This makes `cosmic-osk` show a group change on `super+space`. Previously
a change like that wouldn't be sent until a keyboard input changed the
modifier state, for instance releasing the shift key.
@ids1024
ids1024 requested review from a team September 2, 2026 19:53
@jklgrasso jklgrasso self-assigned this Sep 3, 2026
@Drakulix
Drakulix merged commit 8ec1ffb into master Sep 3, 2026
5 of 8 checks passed
@Drakulix
Drakulix deleted the ei-group branch September 3, 2026 17:32
@trust2k

trust2k commented Oct 7, 2026 •

Copy link
Copy Markdown

Most likely, this change has broken the correct keyboard layout switching, which is very annoying — sometimes it doesn’t switch at all, sometimes it does with delays, and sometimes only halfway (the characters remain in the previous layout). Please fix it: pop-os/cosmic-epoch#3899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants