Skip to content

fix: Do not magnify cursor when there is an active grab. - #2790

Merged
Drakulix merged 1 commit into
pop-os:masterfrom
l-const:shake-pointer-grab-activation
Sep 2, 2026
Merged

Drakulix merged 1 commit into
pop-os:masterfrom
l-const:shake-pointer-grab-activation

Conversation

@l-const

@l-const l-const commented Aug 28, 2026 •

Copy link
Copy Markdown
Contributor
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

fixes #2789

Kwin seems to have a similar check here: https://github.com/KDE/kwin/blob/5f2b2b20dabb764d6cdf38bd8d015181817d3916/src/plugins/shakecursor/shakecursor.cpp#L114-L121 , although not so familiar with that code.
Before:

Video_2026-08-28_20-53-57.mp4

After:

Video_2026-08-28_22-21-47.mp4

KDE:

Video_2026-08-28_20-51-49.mp4

@l-const

l-const commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor Author

kwin seems to have other checks related to a notion of pointer lock and the pointer constraints protocol https://wayland.app/protocols/pointer-constraints-unstable-v1 (e.g. for games) that i am not familiar with. anyway i think this is a small fix and a good start. I generally do not play games, so i can't test any of those scenarios, but kwin's code may indicate that there are more cases where this cursor effect should not apply

@Drakulix Drakulix left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks!

@Drakulix
Drakulix requested a review from a team August 31, 2026 17:12
@jklgrasso jklgrasso self-assigned this Aug 31, 2026
@Drakulix
Drakulix merged commit 9059873 into pop-os:master Sep 2, 2026
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Shake pointer to locate - should not happen when there is an active grab

3 participants