Skip to content

fix(audio): source volume slider applies to sink instead of source - #1533

Merged
mmstick merged 1 commit into
masterfrom
volume
Aug 26, 2026
Merged

mmstick merged 1 commit into
masterfrom
volume

Conversation

@mmstick

@mmstick mmstick commented Aug 21, 2026 •

Copy link
Copy Markdown
Member

Regression. Changing the microphone volume slider will apply that volume to the speaker instead of the microphone. May need to add a newtype for preventing sink/source volumes getting mixed up.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@mmstick
mmstick requested review from a team August 21, 2026 14:15
@jacobgkau

Copy link
Copy Markdown
Member

Was #1482 what this was a regression from?

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes the input slider in the applet-- it used to control the output volume (which also moved the output slider), but after this change, it correctly changes the input volume instead.

All other features of the audio applet are working as expected; that applet is the only one being touched by this PR.

@mmstick

mmstick commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

Yes, a regression from the debounce PR

@mmstick
mmstick merged commit c7b1cb3 into master Aug 26, 2026
11 checks passed
@mmstick
mmstick deleted the volume branch August 26, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants