Repository navigation
Conversation
Member
|
Was #1482 what this was a regression from? |
jacobgkau
approved these changes
Aug 21, 2026
jacobgkau
left a comment
Member
There was a problem hiding this comment.
Confirmed this fixes the input slider in the applet-- it used to control the output volume (which also moved the output slider), but after this change, it correctly changes the input volume instead.
All other features of the audio applet are working as expected; that applet is the only one being touched by this PR.
Member
Author
|
Yes, a regression from the debounce PR |
wash2
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression. Changing the microphone volume slider will apply that volume to the speaker instead of the microphone. May need to add a newtype for preventing sink/source volumes getting mixed up.