Repository navigation
Add macOS (darwin) binaries to release distribution - #1255
Merged
Merged
Conversation
Member
|
Thanks for your interest in palantir/policy-bot, @bells17! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Generate changelog in
|
✅ Successfully generated changelog entry!Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. 📋Changelog Preview💡 Improvements
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
The release distribution only ships Linux binaries (
linux-amd64,linux-arm64).Each release asset (
policy-bot-<version>.tgz) contains:Because of this, macOS users who want to run helper commands such as
policy-bot validatelocally have no prebuilt binary to download. It can stillbe installed via
go install, but that requires a Go toolchain and a localbuild. Having a prebuilt binary available for download is much more convenient.
After this PR
==COMMIT_MSG==
Add darwin (macOS) binaries to the release distribution.
darwin/amd64anddarwin/arm64are added to theos-archslist ingodel/config/dist-plugin.yml, so./godelw distnow also produces macOSbinaries and they are bundled into the same release
.tgz:macOS users can now download the release archive and use the prebuilt binary
(e.g. for
policy-bot validate) without needing a Go toolchain.==COMMIT_MSG==
Possible downsides?
additional
bin/<os>-<arch>/directories are added.CGO_ENABLED=0(matching the existing Linuxbuilds), so they cross-compile cleanly and require no new build dependencies.
The Docker image is unaffected since its Dockerfile explicitly references
bin/linux-amd64/policy-bot.