Repository navigation
fix(rtc): keep video pixels pinned through capture and convert FFI re… - #144
Merged
Merged
Conversation
…quests VideoFrame.ToProtoInfo() returned DataPtr and the plane pointers from inside a `fixed` block, so the pin ended before VideoSource.CaptureFrame and VideoFrame.Convert serialized the request and called the native code. A compacting GC in that gap could move the pixel array and leave the FFI reading a stale pointer. This is the same defect fixed for audio in #143.
Contributor
|
Could you publish a new Livekit.Rtc.Dotnet NuGet release containing the fix from PR #143? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…quests
VideoFrame.ToProtoInfo() returned DataPtr and the plane pointers from inside a
fixedblock, so the pin ended before VideoSource.CaptureFrame and VideoFrame.Convert serialized the request and called the native code. A compacting GC in that gap could move the pixel array and leave the FFI reading a stale pointer. This is the same defect fixed for audio in #143.