[danielroe]

🔗 Linked issue

📚 Description

we drop support for older nuxt versions (so we no longer need to try to resolve the loading template from @nuxt/ui-templates - it's been available on nuxt.options for a very long time)

but we still add a fallback - resolving from @nuxt/schema instead of ui-templates

[pkg-pr-new]

• nuxt-cli-playground

  npm i https://pkg.pr.new/create-nuxt@1419
  

  npm i https://pkg.pr.new/nuxi@1419
  

  npm i https://pkg.pr.new/@nuxt/cli@1419
  

commit: 29fed51

[coderabbitai]

📝 Walkthrough

Walkthrough

The change adds cached loading-template resolution from the project’s installed @nuxt/schema. Dev-server loading responses now support optional loading data, await template rendering, and return a 503 fallback when rendering fails. An end-to-end test verifies the response status, refresh header, loading markup, timeout handling, and server cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the loading-template fallback change in the development server.
Description check	✅ Passed	The description explains the removal of older Nuxt support and the fallback resolution from @nuxt/schema.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/loading-page

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/nuxt-cli/src/dev/loading-template.ts`:
- Around line 17-19: Update resolveDefaultLoadingTemplate to replace the single
cached promise with a cache keyed by cwd (or the canonical schema path),
ensuring each project resolves and reuses only its own loading template. Add a
regression test covering two different project directories and verify each
receives the correct template.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f2b4620a-343b-4e21-b101-91567f05a638

📥 Commits

Reviewing files that changed from the base of the PR and between 503f9d6 and 29fed51.

📒 Files selected for processing (3)

• packages/nuxt-cli/src/dev/loading-template.ts
• packages/nuxt-cli/src/dev/utils.ts
• packages/nuxt-cli/test/e2e/dev-loading.spec.ts

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Key the loading-template cache by project.

Line 18 stores one promise for the entire process. The first call fixes the template for all later cwd values. A later dev server can then use another project's @nuxt/schema template and Nuxt version.

Store cached promises in a Map keyed by cwd or by the canonical resolved schema path. Add a regression test that resolves templates for two different project directories.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/nuxt-cli/src/dev/loading-template.ts` around lines 17 - 19, Update
resolveDefaultLoadingTemplate to replace the single cached promise with a cache
keyed by cwd (or the canonical schema path), ensuring each project resolves and
reuses only its own loading template. Add a regression test covering two
different project directories and verify each receives the correct template.

[codspeed]

Merging this PR will not alter performance

✅ 2 untouched benchmarks

---

_{Comparing fix/loading-page (29fed51) with main (503f9d6)}