Repository navigation
fix(vite): generate nitro types in vite builder - #4387
Conversation
|
@p-dubovitsky is attempting to deploy a commit to the Nitro Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: π Files selected for processing (3)
π WalkthroughWalkthroughThe Vite builder now writes Nitro type declarations during setup and debounced dev reloads. A new Vitest suite checks the generated declaration files in both dev-server and production build flows. ChangesVite type generation
Estimated code review effortπ― 2 (Simple) | β±οΈ ~10 minutes Possibly related PRs
π₯ Pre-merge checks | β 4 | β 1β Failed checks (1 warning)
β Passed checks (4 passed)
β¨ Finishing Touchesπ§ͺ Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
π Linked issue
#4379
β Type of change
π Description
Vite builder did not generate Nitro types, so
.nitro/types/declarations were missing during dev and build.This PR makes the Vite builder run Nitro type generation during setup, and also regenerates types after Nitro config changes in dev mode. This makes route, config, and import declarations available for Vite-based projects.
Added tests for both Vite dev and prod builder flows to make sure the expected declaration files are written.
Resolves #4379
π Checklist