Repository navigation
C99 fixes for the configure script - #1720
Merged
Merged
Conversation
The function foo is defined in the C fragment, but the func function is undeclared. This avoids relying on an implicit function declaration, a C language feature that was removed in 1999.
Adjust quoting in the AX_C_PRINTF_STRING_NULL definition. Switch to strstr and include <string.h> instead of <strings.h>. Add missing braces and parentheses. Use double-quote for string literals. The test now reports success on glibc, as expected.
jimklimov
added
CI
Member
|
Decent catches, in line with the #823 and related issues of the "fightwarn effort" that took years to brush up the codebase - thanks! |
jimklimov
reviewed
Nov 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Future C compilers will likely default to language modes which do not support implicit function declarations. Rebuilding nut with an instrumented compiler revealed a few issues in the configure script.