Repository navigation
Add a short sleep between fallback instcmds in usbhid-ups. - #1228
Merged
jimklimov merged 1 commit intoDec 20, 2021
Merged
Conversation
For some devices, missing instcmds are emulated by calling two instcmds that do exist in sequence. For some devices, when these commands arrive too quickly, they are not properly processed. (One, both, or neither of the commands are acted upon.) Adding a 1/8th-second delay (125,000 microseconds) between the two instcmds that make up the fallback command has worked to make the TrippLite AVR750U (new version with the 3024 productId/protocol) behave consistently when using the fallback commands (shutdown.return and shutdown.stayoff). This delay is also short enough that it seems unlikely to cause a problem for any devices which don't exhibit this issue.
jimklimov
approved these changes
Dec 20, 2021
jimklimov
added a commit
to jimklimov/nut
that referenced
this pull request
Dec 21, 2021
…] for NUT v2.7.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some devices, missing instcmds are emulated by calling two
instcmds that do exist in sequence. For some devices, when these
commands arrive too quickly, they are not properly processed. (One,
both, or neither of the commands are acted upon.)
Adding a 1/8th-second delay (125,000 microseconds) between the two
instcmds that make up the fallback command has worked to make the
TrippLite AVR750U (new version with the 3024 productId/protocol)
behave consistently when using the fallback commands (shutdown.return
and shutdown.stayoff). This delay is also short enough that it seems
unlikely to cause a problem for any devices which don't exhibit
this issue.