Skip to content

drivers/tripplite.c: start using the 'X' value - #1048

Merged
jimklimov merged 7 commits into
networkupstools:masterfrom
cottsay:tripplite_x_value
Oct 4, 2021
Merged

jimklimov merged 7 commits into
networkupstools:masterfrom
cottsay:tripplite_x_value

Conversation

@cottsay

@cottsay cottsay commented Jun 18, 2021

Copy link
Copy Markdown
Contributor

Relatively ancient documentation seems to suggest that this 'firmware checksum' value can be used to indicate the firmware generation as well as the capabilities of the UPS, namely the number of independently controllable plugs.

Here is where I got the information, following a hint in the driver's documentation header: https://web.archive.org/web/20161113104958/http://www.kursknet.ru/~boa/ups/stinfo_command.html

I tested the plug control on my SMART2200NET, which has two independently controllable plugs in addition to the all-inclusive load control.

cottsay and others added 5 commits June 18, 2021 10:10
Relatively ancient documentation seems to suggest that this 'firmware
checksum' value can be used to indicate the firmware generation as well
as the capabilities of the UPS, namely the number of independently
controllable plugs.
@jimklimov

jimklimov commented Sep 15, 2021 •

Copy link
Copy Markdown
Member

LGTM, thanks. Finally rectified the CI side (alas, incomplete statuses from aborted test builds are here and corrupt the view) to say: gonna merge in the next merge-spree (to reduce the rebuilds involved) :)

CC @dzomaya

@jimklimov jimklimov added need testing Code looks reasonable, but the feature would better be tested against hardware or OSes ready / gonna merge The PR is in final cycles leading to merge unless someone logs an objection before we hit the button Tripp Lite labels Sep 15, 2021

@aquette aquette left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimklimov
jimklimov merged commit 91afb21 into networkupstools:master Oct 4, 2021
@cottsay
cottsay deleted the tripplite_x_value branch October 4, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need testing Code looks reasonable, but the feature would better be tested against hardware or OSes ready / gonna merge The PR is in final cycles leading to merge unless someone logs an objection before we hit the button Tripp Lite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants