Repository navigation
feat: expose in public api ability to create a ws connection by specifying a WsSocketFactory, and referencing it in WsConnectionOptions. - #332
Merged
Conversation
…fying a WsSocketFactory, and referencing it in WsConnectionOptions. WsConnectionOptions is a ConnectionOptions that exposes `wsFactory?: WsSocketFactory` This enables uses where the runtime is known to provide additional options that may be necessary for the connection but differ from standard W3C `new WebSocket(url)` usages. Signed-off-by: Alberto Ricart <alberto@synadia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WsConnectionOptions is a
ConnectionOptionsthat exposeswsFactory?: WsSocketFactoryThis enables uses where the runtime is known to provide additional non-standard options that may be necessary for the connection but differ from standard W3C
new WebSocket(url)usages.This feature was implemented previously but internal.