Repository navigation
fix(core): use InstanceType for TE and TD type annotations - #298
Merged
Merged
Conversation
With this change, the `TextEncoder` and `TextDecoder` instances are correctly typed as `InstanceType<typeof TextEncoder>` and `InstanceType<typeof TextDecoder>`, respectively. This ensures that the types are inferred correctly, especially in environments where these classes might not be available globally. Refs: nats-io#297
Member
|
The change is innocuous enough - however given your setup on the issue, you'll still get tsc errors if you don't have the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, the
TextEncoderandTextDecoderinstances are correctly typed asInstanceType<typeof TextEncoder>andInstanceType<typeof TextDecoder>, respectively. This ensures that the types are inferred correctly, especially in environments where these classes might not be available globally.Refs: #297
Resolves: #297