Repository navigation
Add support for gathering perf map information in load - #34
Merged
Merged
Conversation
26 tasks done
mstange
marked this pull request as ready for review
March 20, 2023 21:37
Owner
|
I've rebased this against the Jitdump work and added a commit on top which I think should make it work. I haven't tested it yet, though. I'll merge it anyway, and then you can test if it works. |
This should give us symbols when perf-<pid>.map files are used.
mstange
approved these changes
Mar 20, 2023
mstange
left a comment
mstange
left a comment
Owner
There was a problem hiding this comment.
Thank you for the contribution!
mstange
reviewed
Mar 20, 2023
Comment on lines
+259
to
+262
| let mut split = line.splitn(3, ' '); | ||
| let addr = split.next()?; | ||
| let len = split.next()?; | ||
| let symbol_name = split.next()?; |
Owner
There was a problem hiding this comment.
I've changed this to use splitn so that we wouldn't need to glue together the last piece with spaces again. I hope perf.map files always use just a single space as a separator.
Owner
There was a problem hiding this comment.
Oh, yeah, the "spec" says:
Each line has the following format, fields separated with spaces:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for reading information of
perfmappings that can be generated by runtimes, using a very simple format. It's implemented only for theloadcommand, until a nice design is found for therecordstep.Unfortunately, while this correctly loads the symbols from the mapping on my machine, then when the report is displayed in Firefox Profiler's UI, the JIT symbols don't show up. Am I missing something here?