Repository navigation
Prevent "uncaught exceptions" from the PDFFetchStreamRangeReader and PDFNodeStreamRangeReader classes (issue 22171) - #22173
Merged
Conversation
β¦d `PDFNodeStreamRangeReader` classes (issue 22171) This could occur if the document is destroyed before the `read` method is invoked.
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22173 +/- ##
==========================================
- Coverage 90.34% 90.33% -0.02%
==========================================
Files 277 277
Lines 68030 68032 +2
==========================================
- Hits 61461 61455 -6
- Misses 6569 6577 +8
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Harness. π New features to boost your workflow:
|
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 13, 2026
Contributor
Viewer previewποΈ Viewer previews removed. |
timvandermeij
approved these changes
Oct 13, 2026
Collaborator
|
Thank you for hardening this! |
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 13, 2026
This was referenced Nov 3, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could occur if the document is destroyed before the
readmethod is invoked.Edit: This seems more annoying to test compared to the
PDFDataRangeTransportimplementation, and given that the issue looks like it's written entirely by AI that doesn't really make me want to spend a lot of time on this.