Skip to content

Fix JPX images with subsampled components or mismatched component counts - #22169

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:jpx_numcomps
Oct 13, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:jpx_numcomps

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Update the OpenJPEG decoder in order to support any number of components, to pad the missing ones to match the color space and to upsample the subsampled ones.

Use the last filter to detect JPX and JBIG2 images.

Update the OpenJPEG decoder in order to support any number of components, to pad the missing ones to match the color space and to upsample the subsampled ones.

Use the last filter to detect JPX and JBIG2 images.
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for a72eb15 (run, references from mozilla/pdf.js.refs@23d8c278ca).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1395 13m 25s 0 0 0 2
Windows ⚠️ 1395 18m 11s 0 0 0 2

The report is kept for 30 days and replaced by the next run.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

πŸ—‘οΈ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 13, 2026
@codecov-commenter

codecov-commenter commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 90.33%. Comparing base (e1412d3) to head (a72eb15).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22169      +/-   ##
==========================================
+ Coverage   90.31%   90.33%   +0.02%     
==========================================
  Files         277      277              
  Lines       68004    68032      +28     
==========================================
+ Hits        61418    61460      +42     
+ Misses       6586     6572      -14     
Flag Coverage Ξ”
browsertest 66.20% <100.00%> (+0.01%) ⬆️
fonttest 8.98% <0.00%> (-0.01%) ⬇️
integrationtest 69.36% <100.00%> (+0.01%) ⬆️
unittest 60.43% <100.00%> (+0.01%) ⬆️
unittestcli 58.33% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 13, 2026
@timvandermeij
timvandermeij merged commit d2931ad into mozilla:master Oct 13, 2026
29 of 30 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

r=me; thanks!

This branch was previously deployed

1 inactive deployment
sync_pdfs β€” a72eb159 Deployed Oct 13, 2026 by calixteman via request #395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants