Repository navigation
Handle document destruction during a hanging range request (issue 22051) - #22164
Merged
Merged
Conversation
Snuffleupagus
temporarily deployed
to
sync_pdfs
October 12, 2026 17:28 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
Reference testsResults for 79dce90 (run, references from mozilla/pdf.js.refs@23d8c278ca).
The report is kept for 30 days and replaced by the next run. |
Codecov Reportβ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22164 +/- ##
==========================================
+ Coverage 90.34% 90.36% +0.02%
==========================================
Files 277 277
Lines 68030 68030
==========================================
+ Hits 61461 61477 +16
+ Misses 6569 6553 -16
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Harness. π New features to boost your workflow:
|
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 12, 2026
Contributor
Viewer previewποΈ Viewer previews removed. |
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 12, 2026
Snuffleupagus
marked this pull request as ready for review
October 12, 2026 19:01
There was a problem hiding this comment.
π‘ Changes recommended
Background range prefetch can produce an unhandled rejection during destruction.
2 open findings
What changed in this PR
Fixes document destruction while a range request is stalled.
Changes:
- Propagates aborted range-request failures.
- Defers cleanup so pending API calls can reject.
- Adds a regression test for issue 22051.
| File | Description |
|---|---|
src/βcore/βchunked_stream.js |
Changes request rejection handling. |
src/βcore/βworker.js |
Allows pending requests to settle before cleanup. |
test/βunit/βapi_spec.js |
Tests destruction during a hanging request. |
π§ Review effort: Balanced
π‘ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Snuffleupagus
force-pushed
the
issue-22051
branch
from
October 13, 2026 09:09
88630c7 to
9dce7c5
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 13, 2026
Snuffleupagus
temporarily deployed
to
sync_pdfs
October 13, 2026 09:17 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 13, 2026
Snuffleupagus
requested review from
calixteman
and removed request for
calixteman
October 13, 2026 12:07
calixteman
reviewed
Oct 13, 2026
Also, avoid any "indirect" calls to `ChunkedStreamManager.prototype.#requestChunks` if loading has been aborted.
Snuffleupagus
force-pushed
the
issue-22051
branch
from
October 13, 2026 14:57
9dce7c5 to
79dce90
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 13, 2026
Snuffleupagus
temporarily deployed
to
sync_pdfs
October 13, 2026 15:00 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 13, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 14, 2026
This was referenced Nov 3, 2026
1 task
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, avoid any "indirect" calls to
ChunkedStreamManager.prototype.#requestChunksif loading has been aborted.