Repository navigation
Let the reftest analyzer load images from absolute URLs - #21928
Merged
Merged
Conversation
calixteman
added
test
To Review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21928 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 269 269
Lines 67534 67534
=======================================
Hits 60989 60989
Misses 6545 6545
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Harness. π New features to boost your workflow:
|
calixteman
force-pushed
the
analyzer-cross-origin
branch
2 times, most recently
from
September 10, 2026 14:57
360801a to
2fe2e2c
Compare
The path of the log is only prepended to relative image paths. An absolute URL is accepted when it points to a reference in mozilla/pdf.js.refs (revision, platform, browser, test id and page are checked, and the URL is rebuilt from a constant prefix); it is then fetched with CORS so that the pixels can be compared. This lets the reference tests report of mozilla/pdf.js.pdfs link the references instead of copying them.
calixteman
force-pushed
the
analyzer-cross-origin
branch
from
September 10, 2026 15:26
2fe2e2c to
da81ae9
Compare
Contributor
Author
|
I'm merging but if you see anything wrong please tell me. |
timvandermeij
removed their request for review
September 11, 2026 18:15
timvandermeij
removed
the
To Review
Collaborator
|
Looks good to me; thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path of the log is only prepended to relative image paths, and images coming from another origin are fetched with CORS so that their pixels can be compared. This lets the reference tests report of mozilla/pdf.js.pdfs point to the references stored in mozilla/pdf.js.refs instead of copying them.