Skip to content

Modernize the MessageHandler class - #21883

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:MessageHandler-modernize
Sep 6, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:MessageHandler-modernize

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Convert the code to use Maps instead of regular Objects, and utilize private class fields.

Convert the code to use Maps instead of regular Objects, and utilize private class fields.
@Snuffleupagus
Snuffleupagus force-pushed the MessageHandler-modernize branch from 0e13a70 to 94c722f Compare September 4, 2026 11:01
@codecov-commenter

codecov-commenter commented Sep 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.
βœ… Project coverage is 90.30%. Comparing base (716aff9) to head (94c722f).

Files with missing lines Patch % Lines
src/shared/message_handler.js 98.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21883      +/-   ##
==========================================
+ Coverage   90.28%   90.30%   +0.01%     
==========================================
  Files         264      264              
  Lines       67273    67276       +3     
==========================================
+ Hits        60737    60751      +14     
+ Misses       6536     6525      -11     
Flag Coverage Ξ”
browsertest 66.31% <92.00%> (+<0.01%) ⬆️
fonttest 8.92% <ΓΈ> (ΓΈ)
integrationtest 69.44% <96.00%> (+0.01%) ⬆️
unittest 58.48% <98.00%> (+<0.01%) ⬆️
unittestcli 57.02% <96.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus
Snuffleupagus marked this pull request as draft September 4, 2026 12:00
@mozilla mozilla deleted a comment from moz-tools-bot Sep 4, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Sep 4, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Sep 4, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Sep 4, 2026
@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/6ce68630aeb6559/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e25215b7f1cce8e/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/9478fc92952ca95/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.241.84.105:8877/5643499215ef953/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/6ce68630aeb6559/output.txt

Total script time: 19.07 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/e25215b7f1cce8e/output.txt

Total script time: 23.77 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/5643499215ef953/output.txt

Total script time: 18.92 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/9478fc92952ca95/output.txt

Total script time: 23.69 mins

  • Regression tests: Passed

@Snuffleupagus
Snuffleupagus marked this pull request as ready for review September 4, 2026 14:54
@timvandermeij
timvandermeij merged commit 9242725 into mozilla:master Sep 6, 2026
25 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Looks good; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants