Skip to content

Update PDFViewerApplication._initializeAutoPrint to handle getJSActions returning a Map (PR 21664 follow-up) - #21716

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:_initializeAutoPrint-jsActions-Map
Aug 6, 2026
Merged

Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:_initializeAutoPrint-jsActions-Map

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

This was overlooked in PR #21664, since the code-path in question isn't invoked when scripting is enabled (which is the default value).

…tions` returning a Map (PR 21664 follow-up)

This was overlooked in PR 21664, since the code-path in question isn't invoked when scripting is enabled (which is the default value).
@codecov-commenter

codecov-commenter commented Aug 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
βœ… Project coverage is 90.04%. Comparing base (5f181fd) to head (3f5b472).

Files with missing lines Patch % Lines
web/app.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21716      +/-   ##
==========================================
+ Coverage   90.03%   90.04%   +0.01%     
==========================================
  Files         264      264              
  Lines       66939    66939              
==========================================
+ Hits        60267    60274       +7     
+ Misses       6672     6665       -7     
Flag Coverage Ξ”
browsertest 66.47% <ΓΈ> (-0.03%) ⬇️
integrationtest 69.36% <0.00%> (+0.01%) ⬆️
unittest 57.97% <ΓΈ> (-0.01%) ⬇️
unittestcli 56.70% <ΓΈ> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

This branch was previously deployed

1 inactive deployment
code-coverage β€” 3f5b472d Deployed Aug 5, 2026 by Snuffleupagus via ubuntu-latest / chrome #1235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

regression release-blocker Blocker for the upcoming release viewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants