Repository navigation
[GeckoView] Add web-digital_signature_properties_manager import map (PR 21247 follow-up) - #21529
Merged
calixteman merged 2 commits intoJul 3, 2026
Conversation
β¦ (PR 21247 follow-up) Currently the GeckoView development viewer, i.e. http://localhost:8888/web/viewer-geckoview.html, is completely broken with the following error: ``` Uncaught TypeError: The specifier βweb-digital_signature_properties_managerβ was a bare specifier, but was not remapped to anything. Relative module specifiers must start with β./β, β../β or β/β. app.js:97:44 ```
β¦er.prototype.setDocument` (PR 21247 follow-up) This corresponds to the initial values of these fields, and they were *already* reset when a (previous) PDF document was closed.
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
July 2, 2026 17:47 — with
GitHub Actions
Inactive
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21529 +/- ##
=======================================
Coverage 89.41% 89.42%
=======================================
Files 262 262
Lines 66762 66758 -4
=======================================
Hits 59696 59696
+ Misses 7066 7062 -4
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Harness. π New features to boost your workflow:
|
web-digital_signature_properties_manager import map (PR 21247 follow-up)
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[GeckoView] Add
web-digital_signature_properties_managerimport map (PR 21247 follow-up)Currently the GeckoView development viewer, i.e. http://localhost:8888/web/viewer-geckoview.html, is completely broken with the following error:
Remove unnecessary class-field resetting in
SignaturePropertiesManager.prototype.setDocument(PR 21247 follow-up)This corresponds to the initial values of these fields, and they were already reset when a (previous) PDF document was closed.