Skip to content

[GeckoView] Add web-digital_signature_properties_manager import map (PR 21247 follow-up) - #21529

Merged
calixteman merged 2 commits into
mozilla:masterfrom
Snuffleupagus:SignaturePropertiesManager-geckoview
Jul 3, 2026
Merged

calixteman merged 2 commits into
mozilla:masterfrom
Snuffleupagus:SignaturePropertiesManager-geckoview

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator
  • [GeckoView] Add web-digital_signature_properties_manager import map (PR 21247 follow-up)

    Currently the GeckoView development viewer, i.e. http://localhost:8888/web/viewer-geckoview.html, is completely broken with the following error:

    Uncaught TypeError: The specifier β€œweb-digital_signature_properties_manager” was a bare specifier, but was not remapped to anything. Relative module specifiers must start with β€œ./”, β€œ../” or β€œ/”. app.js:97:44
    
  • Remove unnecessary class-field resetting in SignaturePropertiesManager.prototype.setDocument (PR 21247 follow-up)

    This corresponds to the initial values of these fields, and they were already reset when a (previous) PDF document was closed.

… (PR 21247 follow-up)

Currently the GeckoView development viewer, i.e. http://localhost:8888/web/viewer-geckoview.html, is completely broken with the following error:
```
Uncaught TypeError: The specifier β€œweb-digital_signature_properties_manager” was a bare specifier, but was not remapped to anything. Relative module specifiers must start with β€œ./”, β€œ../” or β€œ/”. app.js:97:44
```
…er.prototype.setDocument` (PR 21247 follow-up)

This corresponds to the initial values of these fields, and they were *already* reset when a (previous) PDF document was closed.
@codecov-commenter

codecov-commenter commented Jul 2, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 89.42%. Comparing base (f7a4abf) to head (12691fd).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21529   +/-   ##
=======================================
  Coverage   89.41%   89.42%           
=======================================
  Files         262      262           
  Lines       66762    66758    -4     
=======================================
  Hits        59696    59696           
+ Misses       7066     7062    -4     
Flag Coverage Ξ”
browsertest 66.51% <ΓΈ> (-0.01%) ⬇️
integrationtest 68.74% <ΓΈ> (+0.01%) ⬆️
unittest 57.33% <ΓΈ> (+<0.01%) ⬆️
unittestcli 56.28% <ΓΈ> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus Snuffleupagus changed the title [GeckoView] Add web-digital_signature_properties_manager import map (PR 21247 follow-up) [GeckoView] Add web-digital_signature_properties_manager import map (PR 21247 follow-up) Jul 2, 2026

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman
calixteman merged commit 44ae5b0 into mozilla:master Jul 3, 2026
17 checks passed
@Snuffleupagus
Snuffleupagus deleted the SignaturePropertiesManager-geckoview branch July 3, 2026 08:51

This branch was previously deployed

1 inactive deployment
code-coverage β€” 12691fdf Deployed Jul 2, 2026 by Snuffleupagus via ubuntu-latest / firefox #262
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants