Skip to content

Add a PDFViewer helper method for setting #printingAllowed and dispatching the event - #21409

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:PDFViewer-#setPrintingAllowed
Jun 9, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:PDFViewer-#setPrintingAllowed

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

This reduces a little bit of code duplication, which shouldn't hurt.

…spatching the event

This reduces a little bit of code duplication, which shouldn't hurt.
@codecov-commenter

codecov-commenter commented Jun 8, 2026 •

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 89.66%. Comparing base (52a44a6) to head (f93faae).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21409   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         260      260           
  Lines       66010    66010           
=======================================
+ Hits        59188    59189    +1     
+ Misses       6822     6821    -1     
Flag Coverage Ξ”
browsertest 66.75% <0.00%> (-0.01%) ⬇️
integrationtest 66.78% <100.00%> (-0.01%) ⬇️
unittest 57.11% <0.00%> (+<0.01%) ⬆️
unittestcli 56.06% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Harness.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit 29ad297 into mozilla:master Jun 9, 2026
19 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Good idea; thanks!

@Snuffleupagus
Snuffleupagus deleted the PDFViewer-#setPrintingAllowed branch June 9, 2026 19:20

This branch was previously deployed

1 inactive deployment
code-coverage β€” f93faae0 Deployed Jun 8, 2026 by Snuffleupagus via ubuntu-latest / chrome #539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants