Repository navigation
Fix intermittent failure in the "must check that a freetext is still here after having updated it and scroll the doc" freetext editor integration test - #21361
Merged
Conversation
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:24 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:24 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:24 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:24 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:24 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:24 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:24 — with
GitHub Actions
Inactive
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21361 +/- ##
==========================================
- Coverage 81.45% 81.45% -0.01%
==========================================
Files 260 260
Lines 65829 65829
==========================================
- Hits 53624 53622 -2
- Misses 12205 12207 +2
Flags with carried forward coverage won't be shown. Click here to find out more. β View full report in Codecov by Sentry. π New features to boost your workflow:
|
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:27 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:27 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:27 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:27 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:30 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:30 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:30 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:30 — with
GitHub Actions
Inactive
timvandermeij
force-pushed
the
is-canvas-monochrome
branch
from
May 30, 2026 14:46
96d1f17 to
d1a764d
Compare
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:46 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:46 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:46 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:46 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:46 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:46 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 30, 2026 14:46 — with
GitHub Actions
Inactive
timvandermeij
marked this pull request as ready for review
May 30, 2026 14:46
β¦there after having updated it and scroll the doc" freetext editor integration test The problem is that we screenshot the page itself rather than the canvas, even though we specifically care about the latter according to the comment, which means that we manually have to take care of hiding and showing the annotation editor. This is problematic because even though we signal that the annotation editor should be hidden, we don't wait until that is actually done, which leads to a situation where we can take the screenshot before the annotation editor is actually invisible in the view. This commit fixes the issue by screenshotting the canvas instead, which avoids the need for manually hiding/showing the annotation editor. This makes the test less fragile, and matches other tests better.
timvandermeij
force-pushed
the
is-canvas-monochrome
branch
from
May 31, 2026 09:36
d1a764d to
add30f3
Compare
timvandermeij
temporarily deployed
to
code-coverage
May 31, 2026 09:37 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 31, 2026 09:37 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 31, 2026 09:37 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 31, 2026 09:37 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 31, 2026 09:37 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 31, 2026 09:37 — with
GitHub Actions
Inactive
timvandermeij
temporarily deployed
to
code-coverage
May 31, 2026 09:37 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that we screenshot the page itself rather than the canvas, even though we specifically care about the latter according to the comment, which means that we manually have to take care of hiding and showing the annotation editor. This is problematic because even though we signal that the annotation editor should be hidden, we don't wait until that is actually done, which leads to a situation where we can take the screenshot before the annotation editor is actually invisible in the view.
This commit fixes the issue by screenshotting the canvas instead, which avoids the need for manually hiding/showing the annotation editor. This makes the test less fragile, and matches other tests better.
Fixes #21362.