Skip to content

Remove the int32 helper, and replace it with DataView usage, in src/core/fonts.js - #21088

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:fonts-rm-int32-helper
Apr 12, 2026
Merged

Remove the int32 helper, and replace it with DataView usage, in src/core/fonts.js#21088
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:fonts-rm-int32-helper

Conversation

@Snuffleupagus

@Snuffleupagus Snuffleupagus commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

This helper function only had a single call-site, and it's easily replaced with a DataView method.
Additionally, to hopefully make future re-factoring easier, create a DataView for each TrueType table.

@Snuffleupagus
Remove the int32 helper, and replace it with DataView usage, in `…
f924526 
…src/core/fonts.js`

This helper function only had a single call-site, and it's easily replaced with a `DataView` method.
Additionally, to hopefully make future re-factoring easier, create a `DataView` for each TrueType table.
@codecov-commenter

codecov-commenter commented Apr 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
βœ… Project coverage is 63.33%. Comparing base (5089cce) to head (f924526).

Files with missing lines Patch % Lines
src/core/fonts.js 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21088      +/-   ##
==========================================
- Coverage   63.35%   63.33%   -0.02%     
==========================================
  Files         177      177              
  Lines      124760   124754       -6     
==========================================
- Hits        79041    79017      -24     
- Misses      45719    45737      +18
Flag Coverage Ξ”
fonttest 7.64% <66.66%> (-0.01%) ⬇️
unittestcli 63.31% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Snuffleupagus commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator Author

/botio unittest

@moz-tools-bot

moz-tools-bot commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a21f09eada43954/output.txt

@moz-tools-bot

moz-tools-bot commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7a02f310593a1a2/output.txt

@moz-tools-bot

moz-tools-bot commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a21f09eada43954/output.txt

Total script time: 2.87 mins

  • Unit Tests: Passed

@moz-tools-bot

moz-tools-bot commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/7a02f310593a1a2/output.txt

Total script time: 6.65 mins

  • Unit Tests: Passed

@Snuffleupagus

Snuffleupagus commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

moz-tools-bot commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d50bd840dd172fe/output.txt

@moz-tools-bot

moz-tools-bot commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d37296d068039f1/output.txt

@moz-tools-bot

moz-tools-bot commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d50bd840dd172fe/output.txt

Total script time: 18.21 mins

  • Regression tests: Passed

@moz-tools-bot

moz-tools-bot commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/d37296d068039f1/output.txt

Total script time: 24.55 mins

  • Regression tests: Passed

@timvandermeij
timvandermeij merged commit 57acd97 into mozilla:master Apr 12, 2026
13 checks passed
@timvandermeij

timvandermeij commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

Thank you!

@Snuffleupagus
Snuffleupagus deleted the fonts-rm-int32-helper branch April 12, 2026 14:47

This branch was previously deployed

1 inactive deployment
code-coverage β€” f924526f Deployed Apr 12, 2026 by Snuffleupagus via Test (lts/*) #1043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

font-conversion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Snuffleupagus @codecov-commenter @moz-tools-bot @timvandermeij