Skip to content

Re-factor the JpegImage class, and related code, to use DataViews when reading data - #21086

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:JpegImage-DataView
Apr 11, 2026
Merged

Re-factor the JpegImage class, and related code, to use DataViews when reading data#21086
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:JpegImage-DataView

Conversation

@Snuffleupagus

@Snuffleupagus Snuffleupagus commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov-commenter

codecov-commenter commented Apr 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 51.11111% with 22 lines in your changes missing coverage. Please review.
βœ… Project coverage is 63.35%. Comparing base (81c9a34) to head (64e5a70).

Files with missing lines Patch % Lines
src/core/jpg.js 51.11% 22 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #21086      +/-   ##
==========================================
+ Coverage   63.32%   63.35%   +0.02%     
==========================================
  Files         177      177              
  Lines      124746   124760      +14     
==========================================
+ Hits        79000    79042      +42     
+ Misses      45746    45718      -28
Flag Coverage Ξ”
fonttest 7.64% <0.00%> (-0.01%) ⬇️
unittestcli 63.32% <51.11%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus

Snuffleupagus commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator Author

/botio unittest

@moz-tools-bot

moz-tools-bot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/61d9c757e545ca3/output.txt

@moz-tools-bot

moz-tools-bot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9c0bd0a444b8fad/output.txt

@moz-tools-bot

moz-tools-bot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/61d9c757e545ca3/output.txt

Total script time: 2.83 mins

  • Unit Tests: Passed

@moz-tools-bot

moz-tools-bot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/9c0bd0a444b8fad/output.txt

Total script time: 6.83 mins

  • Unit Tests: Passed

@Snuffleupagus

Snuffleupagus commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@Snuffleupagus
Snuffleupagus marked this pull request as draft April 11, 2026 10:28
@mozilla mozilla deleted a comment from moz-tools-bot Apr 11, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Apr 11, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Apr 11, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Apr 11, 2026
@Snuffleupagus

Snuffleupagus commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

moz-tools-bot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5ed20baa55f4e0d/output.txt

@moz-tools-bot

moz-tools-bot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/62a7af05e4e0d6d/output.txt

@moz-tools-bot

moz-tools-bot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5ed20baa55f4e0d/output.txt

Total script time: 18.41 mins

  • Regression tests: Passed

@moz-tools-bot

moz-tools-bot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/62a7af05e4e0d6d/output.txt

Total script time: 24.91 mins

  • Regression tests: Passed

@Snuffleupagus
Snuffleupagus marked this pull request as ready for review April 11, 2026 11:13
calixteman
calixteman approved these changes Apr 11, 2026
View reviewed changes

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Snuffleupagus merged commit 5089cce into mozilla:master Apr 11, 2026
13 checks passed
@Snuffleupagus
Snuffleupagus deleted the JpegImage-DataView branch April 11, 2026 15:35

This branch was previously deployed

1 inactive deployment
code-coverage β€” 64e5a702 Deployed Apr 11, 2026 by Snuffleupagus via Test (lts/*) #1040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calixteman calixteman calixteman approved these changes

Assignees

No one assigned

Labels

image-conversion image-jpeg

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Snuffleupagus @codecov-commenter @moz-tools-bot @calixteman