Skip to content

Take into account the alignment when printing/saving a comb field - #21069

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:issue21068
Apr 10, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:issue21068

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

It fixes #21068.

@codecov-commenter

codecov-commenter commented Apr 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
βœ… Project coverage is 63.34%. Comparing base (a67b952) to head (3d54429).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/core/annotation.js 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21069      +/-   ##
==========================================
+ Coverage   63.30%   63.34%   +0.03%     
==========================================
  Files         177      177              
  Lines      124762   124772      +10     
==========================================
+ Hits        78984    79039      +55     
+ Misses      45778    45733      -45     
Flag Coverage Ξ”
fonttest 7.66% <ΓΈ> (ΓΈ)
unittestcli 63.32% <72.72%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mozilla mozilla deleted a comment from moz-tools-bot Apr 9, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Apr 9, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Apr 9, 2026
@mozilla mozilla deleted a comment from moz-tools-bot Apr 9, 2026
@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c75b71f5c9709b9/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c7397bb8d3cee17/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/c7397bb8d3cee17/output.txt

Total script time: 6.59 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/c7397bb8d3cee17/reftest-analyzer.html#web=eq.log

@calixteman

Copy link
Copy Markdown
Contributor Author

/botio-windows test

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6db310bf9150563/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/c75b71f5c9709b9/output.txt

Total script time: 46.21 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/c75b71f5c9709b9/reftest-analyzer.html#web=eq.log

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/6db310bf9150563/output.txt

Total script time: 76.76 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/6db310bf9150563/reftest-analyzer.html#web=eq.log

@calixteman

Copy link
Copy Markdown
Contributor Author

/botio test

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/95ea1d459c7f36f/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/55a29b055361fb0/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/95ea1d459c7f36f/output.txt

Total script time: 46.09 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/95ea1d459c7f36f/reftest-analyzer.html#web=eq.log

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/55a29b055361fb0/output.txt

Total script time: 77.35 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/55a29b055361fb0/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, assuming that the change in the reference tests has been verified to be expected. Thanks!

@calixteman

calixteman commented Apr 10, 2026 •

Copy link
Copy Markdown
Contributor Author

r=me, assuming that the change in the reference tests has been verified to be expected. Thanks!

The Arabic string was better represented but it was due to the bug. I'll fix in a follow up to take into account the text direction.

@calixteman
calixteman merged commit 7cfcafb into mozilla:master Apr 10, 2026
13 checks passed
@calixteman

Copy link
Copy Markdown
Contributor Author

/botio makeref

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d03ff6a1c711c29/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b254faa876908e5/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/d03ff6a1c711c29/output.txt

Total script time: 18.24 mins

  • Make references: Passed
  • Check references: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/b254faa876908e5/output.txt

Total script time: 24.43 mins

  • Make references: Passed
  • Check references: Passed

This branch was previously deployed

1 inactive deployment
code-coverage β€” 3d544294 Deployed Apr 9, 2026 by calixteman via Test (lts/*, ubuntu-latest) #4402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: numbers in Massachusetts tax forms aligned incorrectly when entered with Firefox and either printed in firefox or viewed in evince

4 participants